Add Chat Sharing Dialog & BugFix Empty History #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Originally #124 - thank you @fedebotu for this great contribution!!]
This PR adds the following improvements:
1. Add Chat Sharing Dialog
Previously, a user had to manually copy the
thread_idto the service URL and set it as a query parameter. Now, a new dialog appears that allows users to conveniently copy the full link for sharing/resuming chats:2. BugFix Empty History
If the user tried for any reason to open a new chat with a
thread_idwith no messages yet, the below error appeared:This PR fixes this issue by simply checking whether there is any history. If there is not, a simple error popup appears, avoiding the crash: