Update master branch to v2.0.0 #81
Conversation
|
Marking the 2.0 versions as drafts because it seems that when they are run in development mode they do not produce blocks 🤔 |
| @@ -48,7 +50,7 @@ The following example takes you through a scenario where: | |||
|
|
|||
| 1. Compile and build a release node | |||
| ```bash | |||
| cargo build --release | |||
| cargo +nightly-2020-10-05 build --release | |||
There was a problem hiding this comment.
Consider using a rust-toolchain file.
docs: https://rust-lang.github.io/rustup/overrides.html?highlight=rust-toolchain#the-toolchain-file
example: https://github.com/PureStake/moonbeam/blob/master/rust-toolchain
| @@ -197,7 +195,7 @@ pub fn new_light(config: Configuration, sr25519_public_key: sr25519::Public) -> | |||
| client.clone(), | |||
| Sha3Algorithm::new(client.clone()), | |||
| 0, // check inherents starting at block 0 | |||
| Some(select_chain), | |||
| select_chain, | |||
| inherent_data_providers.clone(), | |||
| // TODO what should I Really use here? This compiles, and the `can_author_with` from line 196 doesn't?? | |||
There was a problem hiding this comment.
Is "line 196" still a valid reference?
| @@ -197,7 +195,7 @@ pub fn new_light(config: Configuration, sr25519_public_key: sr25519::Public) -> | |||
| client.clone(), | |||
| Sha3Algorithm::new(client.clone()), | |||
| 0, // check inherents starting at block 0 | |||
| Some(select_chain), | |||
| select_chain, | |||
| inherent_data_providers.clone(), | |||
| // TODO what should I Really use here? This compiles, and the `can_author_with` from line 196 doesn't?? | |||
There was a problem hiding this comment.
| // TODO what should I Really use here? This compiles, and the `can_author_with` from line 196 doesn't?? | |
| // TODO what should I Really use here? This compiles, and the `can_author_with` from above doesn't?? |
I have this question, too, LGTM otherwise |
|
@JoshOrndorff & @apopiak - Regarding the fact that blocks are not being authored in
|
|
When I add |
|
The miner is started but does not seem to do anything useful? |
| @@ -153,19 +153,17 @@ pub fn new_full(config: Configuration, sr25519_public_key: sr25519::Public) -> R | |||
| let can_author_with = | |||
| sp_consensus::CanAuthorWithNativeVersion::new(client.executor().clone()); | |||
|
|
|||
| sc_consensus_pow::start_mine( | |||
| sc_consensus_pow::start_mining_worker( | |||
There was a problem hiding this comment.
This is started, but does not seem to actually mine anything.
|
Closing it as it has been a while. |
Relates to #79 and #80. I am also working on updating the
workshopbranch to v2.0.0CC: @JoshOrndorff