Make dnspython package is optional #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not opposed to the idea, but it would have to wait for the next major version update (e.g. a 3.x) since it would change default behavior, and at this time I don't really foresee a 3.x because I don't see any other changes motivated for it. |
JoshData
force-pushed
the
main
branch
2 times, most recently
from
0df8b7a to
dbf4618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make
dnspythonpackage optional, due to deliverability is optional as well.It reduces installed dependencies if we don't check
deliverability. ProbablyCHECK_DELIVERABILITYconstant also should be changed toFalse, but it's change default behavior.