Exposing a version str & deprecating the email attribute #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commonism
added a commit
to commonism/pydantic
that referenced
this pull request
May 15, 2023
will use email_validator.__version__ if available (JoshData/python-email-validator#110)
|
Thanks for this! Is this OK to merge (you've got "WIP" in the title)? |
commonism
changed the title
|
LGTM? |
|
Thanks! |
commonism
added a commit
to commonism/pydantic
that referenced
this pull request
Jun 7, 2023
will use email_validator.__version__ if available (JoshData/python-email-validator#110)
commonism
added a commit
to commonism/pydantic
that referenced
this pull request
Jun 7, 2023
will use email_validator.__version__ if available (JoshData/python-email-validator#110)
5 tasks
commonism
added a commit
to commonism/pydantic
that referenced
this pull request
Nov 13, 2023
will use email_validator.__version__ if available (JoshData/python-email-validator#110)
commonism
added a commit
to commonism/pydantic
that referenced
this pull request
Nov 14, 2023
will use email_validator.__version__ if available (JoshData/python-email-validator#110)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.cfg prefers having the version string not in __init__.py to avoid imports of libraries not installed yet.
And I added some glue for email property compat, could be extended to __getitem__("email") as well.