Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <cstdint> header to avoid compilation errors on GCC 13 #616

Merged

Conversation

mairacanal
Copy link
Contributor

@mairacanal mairacanal commented Feb 1, 2023

Currently, when compiling with GCC 13, the following error is displayed:

In file included from /builddir/build/BUILD/touchegg-2.0.15/src/actions/action.h:26,
                 from /builddir/build/BUILD/touchegg-2.0.15/src/actions/action.cpp:18:
/builddir/build/BUILD/touchegg-2.0.15/src/gesture/gesture.h:32:58: error: 'uint64_t' has not been declared
    32  |          int fingers, DeviceType performedOnDeviceType, uint64_t elapsedTime)
        |                                                         ^~~~~~~~

/builddir/build/BUILD/touchegg-2.0.15/src/gesture/gesture.h:72:3: error: 'uint64_t' does not name a type
    72  |   uint64_t elapsedTime() const { return this->gestureElapsedTime; }
        |   ^~~~~~~~

/builddir/build/BUILD/touchegg-2.0.15/src/gesture/gesture.h:22:1: note: 'uint64_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
    21  | #include "gesture/device-type.h"
    +++ |+#include <cstdint>
    22  | #include "gesture/gesture-direction.h"

/builddir/build/BUILD/touchegg-2.0.15/src/gesture/gesture.h:88:3: error: 'uint64_t' does not name a type
    88  |   uint64_t gestureElapsedTime = -1;
        |   ^~~~~~~~

/builddir/build/BUILD/touchegg-2.0.15/src/gesture/gesture.h:88:3: note: 'uint64_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?

/builddir/build/BUILD/touchegg-2.0.15/src/gesture/gesture.h: In constructor 'Gesture::Gesture(GestureType, GestureDirection, double, int, DeviceType, int)':

/builddir/build/BUILD/touchegg-2.0.15/src/gesture/gesture.h:38:9: error: class 'Gesture' does not have any field named 'gestureElapsedTime'
    38  |   gestureElapsedTime(elapsedTime) {}
        |   ^~~~~~~~~~~~~~~~~~

I'm the current maintainer of the Fedora package, which is not currently building due to this error [1].

[1] https://koschei.fedoraproject.org/package/touchegg?collection=f38

Currently, when compiling with GCC 13, the following error is displayed:

In file included from /builddir/build/BUILD/touchegg-2.0.15/src/actions/action.h:26,
                 from /builddir/build/BUILD/touchegg-2.0.15/src/actions/action.cpp:18:
/builddir/build/BUILD/touchegg-2.0.15/src/gesture/gesture.h:32:58:
error: 'uint64_t' has not been declared
    32  |          int fingers, DeviceType performedOnDeviceType, uint64_t elapsedTime)
        |                                                         ^~~~~~~~

/builddir/build/BUILD/touchegg-2.0.15/src/gesture/gesture.h:72:3:
error: 'uint64_t' does not name a type
    72  |   uint64_t elapsedTime() const { return this->gestureElapsedTime; }
        |   ^~~~~~~~

/builddir/build/BUILD/touchegg-2.0.15/src/gesture/gesture.h:22:1:
note: 'uint64_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
    21  | #include "gesture/device-type.h"
    +++ |+#include <cstdint>
    22  | #include "gesture/gesture-direction.h"

/builddir/build/BUILD/touchegg-2.0.15/src/gesture/gesture.h:88:3: error: 'uint64_t'
does not name a type
    88  |   uint64_t gestureElapsedTime = -1;
        |   ^~~~~~~~

/builddir/build/BUILD/touchegg-2.0.15/src/gesture/gesture.h:88:3: note: 'uint64_t'
is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?

/builddir/build/BUILD/touchegg-2.0.15/src/gesture/gesture.h: In constructor
'Gesture::Gesture(GestureType, GestureDirection, double, int, DeviceType, int)':

/builddir/build/BUILD/touchegg-2.0.15/src/gesture/gesture.h:38:9: error: class
'Gesture' does not have any field named 'gestureElapsedTime'
    38  |   gestureElapsedTime(elapsedTime) {}
        |   ^~~~~~~~~~~~~~~~~~
@JoseExposito JoseExposito merged commit a458bc8 into JoseExposito:master Feb 6, 2023
@JoseExposito
Copy link
Owner

Hi Maíra,

Thanks a lot for maintaining the Fedora packages and for sending the fix upstream.

I can tag a new release if that makes your life easier.

@mairacanal
Copy link
Contributor Author

Creating a new release would be great! This way I wouldn't have to create a patch downstream. Thanks for the help!

@JoseExposito
Copy link
Owner

Cool, I just released v2.0.16 fixing the GCC 13 issue: https://github.com/JoseExposito/touchegg/releases/tag/2.0.16

Thanks a lot!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants