Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no API to delete notifications #14

Closed
basilevs opened this issue Oct 11, 2023 · 1 comment · Fixed by #15
Closed

There is no API to delete notifications #14

basilevs opened this issue Oct 11, 2023 · 1 comment · Fixed by #15

Comments

@basilevs
Copy link
Contributor

basilevs commented Oct 11, 2023 •
edited
Loading

There is no way to close a notification.

For example, there is no need to keep showing "unread messages" notification after messages are read, but the library can't stop showing it.
@Jorricks
Copy link
Owner

Yeah that is a good point. I'm not aware of whether it would be possible to implement this or not. Nice idea for a next iteration.

basilevs added a commit to basilevs/macos-notifications that referenced this issue Oct 13, 2023
@basilevs
Jorricks#14 Refactored to use a single side-car process
417473b
basilevs added a commit to basilevs/macos-notifications that referenced this issue Oct 13, 2023
@basilevs
Jorricks#14 Removed redundant Event
e820ba1
basilevs added a commit to basilevs/macos-notifications that referenced this issue Oct 13, 2023
@basilevs
Jorricks#14 Extracted resource cleanup to a dedicated class
0037e80
basilevs added a commit to basilevs/macos-notifications that referenced this issue Oct 13, 2023
@basilevs
Jorricks#14 Removed redundant method
e0899ef
basilevs added a commit to basilevs/macos-notifications that referenced this issue Oct 13, 2023
@basilevs
Jorricks#14 Eliminate leaking notification index
1a4884d
basilevs added a commit to basilevs/macos-notifications that referenced this issue Oct 13, 2023
@basilevs
Jorricks#14 Cancel notifications feature
df69b23
@basilevs basilevs mentioned this issue Oct 13, 2023
Merged
basilevs added a commit to basilevs/macos-notifications that referenced this issue Nov 3, 2023
@basilevs
Fix typing and import styles Jorricks#14
65f49fe
Jorricks pushed a commit that referenced this issue Feb 4, 2024
@basilevs
✨ #14 Implement notification cancellation (#15)
76dbd33 
#14 Cancel notifications feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#14 Implement notification cancellation basilevs/macos-notifications
2 participants
@basilevs @Jorricks