Fix respond_to? method signature for optional second positional arg #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dalton's rails 7.1 upgrade uncovered this. rails 7.1 makes the broadcast logger api public https://github.com/rails/rails/blob/7-1-stable/activesupport/CHANGELOG.md#rails-710rc1-september-27-2023. during our db seed process the broadcast logger calls
respond_to?
with the optional second positional arg: https://github.com/rails/rails/blob/7-1-stable/activesupport/lib/active_support/broadcast_logger.rb#L239 this was causing anArgumentError: wrong number of arguments (given 2, expected 1)
in lorekeeper because lorekeeper has the second arg declared as a kwarg. as far as i can tell it's never been a kwarg but probably nothing has attempted to call it with a second positional arg