Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colliders without RigidBody not working #323

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

Jondolf
Copy link
Owner

@Jondolf Jondolf commented Feb 12, 2024

Objective

On the main branch, collisions between colliders without a RigidBody component are currently not detected. This is because some queries are overly strict and require components that only rigid bodies have.

Solution

Make some components in queries optional in order to fix non-rigidbody colliders.

@Jondolf Jondolf added bugfix A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality labels Feb 12, 2024
@Jondolf Jondolf merged commit 23ca1be into main Feb 12, 2024
4 checks passed
@Jondolf Jondolf deleted the fix-non-rb-colliders branch February 12, 2024 18:29
brianreavis pushed a commit to naturalatlas/bevy_xpbd that referenced this pull request Feb 17, 2024
# Objective

On the main branch, collisions between colliders without a `RigidBody` component are currently not detected. This is because some queries are overly strict and require components that only rigid bodies have.

## Solution

Make some components in queries optional in order to fix non-rigidbody colliders.
@Jondolf Jondolf added C-Bug Something isn't working and removed bugfix labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality C-Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant