Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Transform interpolation #444

Open
Tracked by #433
, #441
...
janhohenheim opened this issue Jul 17, 2024 · 1 comment · May be fixed by #566
Open
Tracked by #433
, #441
...

Support Transform interpolation #444

janhohenheim opened this issue Jul 17, 2024 · 1 comment · May be fixed by #566
Labels
C-Enhancement New feature or request
Milestone
0.2

Comments

@janhohenheim
Copy link
Contributor

janhohenheim commented Jul 17, 2024 •
edited
Loading

@janhohenheim janhohenheim mentioned this issue Jul 17, 2024
Open
9 tasks
@Jondolf Jondolf added the C-Enhancement New feature or request label Jul 19, 2024
@Jondolf Jondolf mentioned this issue Jul 20, 2024
Open
6 tasks
@Jondolf Jondolf added this to the 0.2 milestone Aug 23, 2024
@janhohenheim
Copy link
Contributor Author

See my crate avian_interpolation for a suggestion for how to handle this. It's not fit for being directly upstreamed as it completely removes the transform sync, which would be a much more controversial change, but it should be a good starting point. Another option is to just use bevy_transform_interpolation and accept the fact that it necessarily stores redundant data.

@janhohenheim janhohenheim mentioned this issue Sep 10, 2024
Merged
Jondolf pushed a commit that referenced this issue Sep 26, 2024
@janhohenheim
Allow interpolation of scales (#512)
39a7480 
# Objective

For [`avian_interpolation`](https://github.com/janhohenheim/avian_interpolation), I want to have a clean separation between gameplay transforms and render transforms. Avian's best version of a gameplay scale is currently `Collider::scale`. However, this is not ergonomically interpolatable due to two reasons:
- `Collider::scale` is not initialized with the right scale, meaning that my observers that listen for its insertion will read wrong initial data, and
- It is automatically synced to the `GlobalTransform`, making it hard to change the `Transform` according to the `Collider::scale` without affecting it back in turn

Related to #444 

## Solution

- Set the `Collider::scale` correctly in its `on_add` hook
- Allow an opt-out via `SyncConfig`

---

## Changelog

- You can now opt-out of `Transform` to `Collider::scale` syncing by using the new `SyncConfig::transform_to_collider_scale` field.
@Jondolf Jondolf linked a pull request Nov 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Enhancement New feature or request
Projects
None yet
Milestone
0.2
Development

Successfully merging a pull request may close this issue.

Physics Interpolation and Extrapolation Jondolf/avian
2 participants
@janhohenheim @Jondolf