fix(tests): fix actions, add validation tests

Jon-Becker · Apr 12, 2024 · 566742b · 566742b
1 parent d5d002c
commit 566742b
Show file tree

Hide file tree

Showing 4 changed files with 62 additions and 83 deletions.
diff --git a/.github/workflows/safety-check.yaml b/.github/workflows/safety-check.yaml
diff --git a/.github/workflows/tests-merged.yaml b/.github/workflows/tests-merged.yaml
@@ -3,6 +3,8 @@ name: Unit Tests (on PR)
 on:
   push:
     branches: [ "main" ]
+  pull_request:
+    branches: [ "main" ]
 
 permissions:
   contents: read

diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
diff --git a/tests/test_validate_config.py b/tests/test_validate_config.py
@@ -45,6 +45,66 @@ def test_validate_config_missing_key():
         validate_config(config)
 
 
+def test_validate_config_layer_mismatch_weights():
+    config = {
+        "layers": [
+            {
+                "name": "Background",
+                "values": ["Python Logo", "some other value"],
+                "trait_path": "./trait-layers/foreground",
+                "filename": ["logo", "some file"],
+                "weights": [100],
+            }
+        ],
+        "baseURI": ".",
+        "name": "NFT #",
+        "description": "This is a description for this NFT series.",
+    }
+
+    with pytest.raises(ConfigValidationError):
+        validate_config(config)
+
+
+def test_validate_config_layer_mismatch_filename():
+    config = {
+        "layers": [
+            {
+                "name": "Background",
+                "values": ["Python Logo", "some other value"],
+                "trait_path": "./trait-layers/foreground",
+                "filename": ["logo"],
+                "weights": [100, 100],
+            }
+        ],
+        "baseURI": ".",
+        "name": "NFT #",
+        "description": "This is a description for this NFT series.",
+    }
+
+    with pytest.raises(ConfigValidationError):
+        validate_config(config)
+
+
+def test_validate_config_layer_mismatch_values():
+    config = {
+        "layers": [
+            {
+                "name": "Background",
+                "values": ["Python Logo"],
+                "trait_path": "./trait-layers/foreground",
+                "filename": ["logo", "logo 2"],
+                "weights": [100, 100],
+            }
+        ],
+        "baseURI": ".",
+        "name": "NFT #",
+        "description": "This is a description for this NFT series.",
+    }
+
+    with pytest.raises(ConfigValidationError):
+        validate_config(config)
+
+
 def test_validate_config_incorrect_type():
     config = {
         "layers": "should be a list",