Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vm): update minimum gas used for various opcodes #479

Closed
wants to merge 2 commits into from
Closed

fix(vm): update minimum gas used for various opcodes #479

wants to merge 2 commits into from

Conversation

KnowHowToKnowWhere
Copy link

Incorrect mingas issue for sload and sstore

Motivation

Solution

@KnowHowToKnowWhere
Update opcodes.rs
90d76fe 
Incorrect mingas issue for sload and sstore
@KnowHowToKnowWhere
Copy link
Author

It is just trivial.

@Jon-Becker
Copy link
Owner

great catch <3

@Jon-Becker Jon-Becker changed the title Update opcodes.rs fix(vm): update minimum gas used for various opcodes Aug 12, 2024
Jon-Becker
Jon-Becker requested changes Aug 12, 2024
View reviewed changes
Copy link
Owner

@Jon-Becker Jon-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in crates/vm/src/core/vm.rs Line 1305, can you remove (375 * (topic_count as u128)) +?

@Jon-Becker
Copy link
Owner

Resolved in #481 perf improvements

@Jon-Becker Jon-Becker closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jon-Becker Jon-Becker Jon-Becker requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KnowHowToKnowWhere @Jon-Becker