Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

general fixes to yield-generator.py #314

Closed
wants to merge 2 commits into from

Conversation

urban48
Copy link

@urban48 urban48 commented Nov 8, 2015

fixed pep8
better imports
new style class inheritance fixed
made code more readble in general

better imports
new style class inheritance
code more readble in general
@adlai
Copy link
Contributor

adlai commented Nov 9, 2015

I'm in favor of this kind of cleanup, but this commit also adds extra whitespace...

@urban48
Copy link
Author

urban48 commented Nov 9, 2015

@adlai well, its a change from tab indentation to space indentation, because of pep8

nickname = random_nick()
nickserv_password = ''
minsize = int(1.2 * txfee / float(cjfee)) #minimum size is such that you always net profit at least 20% of the miner fee
minsize = int(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed :)

@adlai
Copy link
Contributor

adlai commented Nov 9, 2015

Perhaps it's better to pool your efforts with @ghtdak on #254

@urban48
Copy link
Author

urban48 commented Nov 9, 2015

i will, tnx

@AdamISZ
Copy link
Member

AdamISZ commented Dec 7, 2015

Formatting has been addressed for the whole codebase by #345 and the is in the develop branch
#349 has created alternative yieldgenerator scripts.

If there's something still worth changing, please submit a new PR against the develop branch, but bear in small refactoring there will be low priority for now. See #343 for the current plan for progress.

@AdamISZ AdamISZ closed this Dec 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants