This repository has been archived by the owner on May 13, 2022. It is now read-only.
Move yieldgen configuration to joinmarket.cfg #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h is now in the wiki
… only used for testnet
…re starting, --yes will skip
… sending error to taker
Implemented socks5 proxy
- Copy/paste brief explanation of what JoinMarket is from wiki. Should be quickly explained on the landing page. - Change install dependencies from numbered list to bullets. With two numbered lists the steps look a bit daunting at first glance. - Added 4th step since we've had a few new people recently not realize that the config is populated on first run, causing some confusion. I believe this also eliminates the need for the note near the end about putting mainnet in the config. - Reformatted already existing information.
Update readme and change .txt to .md
Waits 10 seconds by default, any nonrespondants after that are added to a local blacklist that persists until the taker is restarted. Changed sendpayment and tumbler so they recover, seems to work Sending of spent UTXO by maker no longer crashes taker, this is possible with the timeout recovery code
…letnotify could work, fixed some spelling mistakes
… timeout, now irc code disregards messaged with unknown encryption
…t work out to 30%
…o made it far more scalable
…ion is persistent.
orderbook.html: select specific orders with a single click
|
It seems like nobody's looked at this? It seems like an entirely sensible idea, and simple. But: did you notice that we have a required_options dict at the top of common.py, so you could enter these fields into the joinmarket.cfg file, and put it in the default version of course. Then you wouldn't have to load the fields individually. Of course, these fields would just be ignored by the taker scripts. Also, squash commits into 1 please. |
|
We have 3 yeildgens in develop now. Organizing the config still needs to be done, but will need to be done in a different way which takes into account options which are shared across all yieldgens and options that are specific that that yieldgen. I suggest this pull request is closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.