Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Taker on_pubkey() should verify existence of CoinJoinTx object #185

Open
AdamISZ opened this issue Aug 10, 2015 · 1 comment
Open

Taker on_pubkey() should verify existence of CoinJoinTx object #185

AdamISZ opened this issue Aug 10, 2015 · 1 comment

Comments

@AdamISZ
Copy link
Member

AdamISZ commented Aug 10, 2015

Here: https://github.com/chris-belcher/joinmarket/blob/master/lib/taker.py#L271-L272

The code assumes that when the pubkey message is received from the taker, the self.cjtx object already exists. This will not be the case if the CoinJoinTx.init() call has not completed. In the current version of the code, this won't happen, but it makes sense to put a sanity check like:

while not self.cjtx:
                      time.sleep(2)
                      debug("waiting for CoinJoinTX instantiation")
@AdamISZ
Copy link
Member Author

AdamISZ commented Aug 10, 2015

It would also make sense to put self.cjtx = None before the call to CoinJoinTx() constructor in start_cj, so that there will not be a mistaken belief that the cjtx has been created (in the above code) when it hasn't (it's an old/stale one)

AdamISZ added a commit to AdamISZ/joinmarket that referenced this issue Dec 16, 2015
Two throttling mechanisms: a limit to lines per second allowed,
and a limit of bytes/second over a recent interval. These settings
are currently in the constructor of the ThrottleThread.
Minor additional update: address issue JoinMarket-Org#185.
AdamISZ added a commit to AdamISZ/joinmarket that referenced this issue Dec 16, 2015
Two throttling mechanisms: a limit to lines per second allowed,
and a limit of bytes/second over a recent interval. These settings
are currently in the constructor of the ThrottleThread.
Minor additional update: address issue JoinMarket-Org#185.
AdamISZ added a commit to AdamISZ/joinmarket that referenced this issue Dec 18, 2015
Two throttling mechanisms: a limit to lines per second allowed,
and a limit of bytes/second over a recent interval. These settings
are currently in the constructor of the ThrottleThread.
Also, edit default maker_timeout_sec to 60.
Minor additional update: address issue JoinMarket-Org#185.
AdamISZ added a commit to AdamISZ/joinmarket that referenced this issue Dec 19, 2015
Two throttling mechanisms: a limit to lines per second allowed,
and a limit of bytes/second over a recent interval. These settings
are currently in the constructor of the ThrottleThread.
Change maker_timeout_seconds default to 60 for large txs.
Remove sleep hack in sig sending, no longer needed.
Minor additional update: address issue JoinMarket-Org#185.

mts 60
AdamISZ added a commit to AdamISZ/joinmarket that referenced this issue Dec 19, 2015
Two throttling mechanisms: a limit to lines per second allowed,
and a limit of bytes/second over a recent interval. These settings
are currently in the constructor of the ThrottleThread.
Change maker_timeout_seconds default to 60 for large txs.
Remove sleep hack in sig sending, no longer needed.
Minor update: tumbler test -w wait time reset to 10s.
Minor additional update: address issue JoinMarket-Org#185.
AdamISZ added a commit to AdamISZ/joinmarket that referenced this issue Dec 19, 2015
Two throttling mechanisms: a limit to lines per second allowed,
and a limit of bytes/second over a recent interval. These settings
are currently in the constructor of the ThrottleThread.
Change maker_timeout_seconds default to 60 for large txs.
Remove sleep hack in sig sending, no longer needed.
Minor updates: tumbler test -w wait time reset to 10s, regtest
yieldgen timeout increased.
Minor additional update: address issue JoinMarket-Org#185.
AdamISZ added a commit to AdamISZ/joinmarket that referenced this issue Dec 20, 2015
Two throttling mechanisms: a limit to lines per second allowed,
and a limit of bytes/second over a recent interval. These settings
are currently in the constructor of the ThrottleThread.
Change maker_timeout_seconds default to 60 for large txs.
Remove sleep hack in sig sending, no longer needed.
Minor updates: tumbler test -w wait time reset to 10s, extra
travis bot logs.
Minor additional update: address issue JoinMarket-Org#185.
AdamISZ added a commit to AdamISZ/joinmarket that referenced this issue Dec 20, 2015
Two throttling mechanisms: a limit to lines per second allowed,
and a limit of bytes/second over a recent interval. These settings
are currently in the constructor of the ThrottleThread.
Change maker_timeout_seconds default to 60 for large txs.
Remove sleep hack in sig sending, no longer needed.
Minor updates: tumbler test -w wait time reset to 10s, extra
travis bot logs.
Minor additional update: address issue JoinMarket-Org#185.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants