Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasize that ygen uses only single UTXO as fbond #982

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

chris-belcher
Copy link
Contributor

At least two people have been burned (see issue #963 for one of them) by creating two transactions sending bitcoins to two timelocked addresses, and then finding that yield-generator announces only one of them.

This commit expands the section talking about how only one UTXO will be used. It also edits the text to refer to yield-generator's fidelity bonds only in the singular, as previously they were referred to in the plural (i.e. "fidelity bonds"), which possibly added to user's confusion.

docs/fidelity-bonds.md Outdated Show resolved Hide resolved
@AdamISZ
Copy link
Member

AdamISZ commented Aug 10, 2021

ACK the language change.

My one nit above is optional.

Copy link
Member

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e7856c7

At least two people have been burned by creating two transactions
sending bitcoins to two timelocked addresses, and then finding that
yield-generator announces only one of them.

This commit expands the section talking about how only one UTXO will
be used. It also edits the text to refer to yield-generator's fidelity
bonds only in the singular, as previously they were referred to in
the plural (i.e. "fidelity bonds"), which possibly added to user's
confusion.
@chris-belcher chris-belcher force-pushed the emphasize-single-utxo-fbond branch from e7856c7 to f7180b8 Compare August 11, 2021 07:38
@chris-belcher chris-belcher merged commit 6d2fa82 into master Aug 11, 2021
@chris-belcher chris-belcher deleted the emphasize-single-utxo-fbond branch August 11, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants