Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-bitcointx to v1.1.1.post0 #694

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Bump python-bitcointx to v1.1.1.post0 #694

merged 1 commit into from
Oct 3, 2020

Conversation

kristapsk
Copy link
Member

Should fix PSBT related incompatibilities with some wallets in BIP78 payjoin receiver.

Related - spesmilo/electrum#6257 and WalletWasabi/WalletWasabi#4427.

Should fix PSBT related incompatibilities with some wallets in BIP78
payjoin receiver.
@AdamISZ
Copy link
Member

AdamISZ commented Oct 3, 2020

ACK (but needs baseline test that JM-JM BIP78 is still working, if someone else does that before me feel free to merge).

@AdamISZ
Copy link
Member

AdamISZ commented Oct 3, 2020

OK I found some spare time, test suite passes - which includes explicit psbt tests and tests of functionality including psbt, and also, didn't take much effort to test that JM sender and receiver of BIP78 is still working fine, albeit that is a trivial sanity test, the more substantial one is checking for Wasabi sender-side compatibility, but I believe that has been done, so merging. (note: to test this i just did pip install --update, just pulling the branch would not of course have been helpful).

@AdamISZ AdamISZ merged commit 0851a8e into JoinMarket-Org:master Oct 3, 2020
@kristapsk
Copy link
Member Author

more substantial one is checking for Wasabi sender-side compatibility, but I believe that has been done

Don't trust, verify! :) I haven't yet tested that one, just did some testing that this does not break anything else before creating this PR (also, it's >=, so this should not have any actual effect on a new installs anyway).

@kristapsk kristapsk deleted the bump-bitcointx branch October 4, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants