Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change defaults for fidelity bond settings. #1253

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

AdamISZ
Copy link
Member

@AdamISZ AdamISZ commented Apr 21, 2022

Closes #1247.
This consists of a change to the default value of
bondless_makers_allowance
(was removed), an inclusion of the bond value exponent into
the config that the user can alter, and a change to the default of that
value from 2 (implicit by quadratic) to 1.3.
Also updates the fidelity bond documentation to account for those
changes.

@AdamISZ
Copy link
Member Author

AdamISZ commented Apr 24, 2022

Comment from @chris-belcher in #1247 (comment) :

Right now all the displays in the software use BTC² as a unit, we should move to something like FBU (short for Fidelity Bond Unit) instead, then we define FBU = BTC^1.3 or something. Previously people would read 100 BTC² and after the update they'd read something like 75 FBU (seventy-five fidelity bond units)

So units would have to be addressed in this PR

@AdamISZ
Copy link
Member Author

AdamISZ commented Apr 29, 2022

Added a commit (which I will squash) to change the units displayed (BTC^n) as a function of the exponent the user has in their config.

Important note: while the fidelity bonds table and the orderbook table should be correct, the sybil resistance calculations are AFAIU now wrong, I am hoping that @chris-belcher can update that, or if not, we can temporarily disable the page until it's correct.

Closes #1247.
This consists of an inclusion of the bond value exponent into the config
that the user can alter, and a change of that from 2 to default 1.3.
Also updates the fidelity bond documentation to account for those
changes, including the units used in ob-watcher, but not the calculation
of fidelity bond attack resistance (which remains a TODO).
@AdamISZ AdamISZ force-pushed the alter-fb-defaults branch from 0f0d5d8 to 044bef6 Compare May 3, 2022 16:26
@AdamISZ
Copy link
Member Author

AdamISZ commented May 3, 2022

Reverted the change to bondless_maker_allowance back to 0.125 but still contains the exponent change (in config, and to 1.3 by default).

This is based on us having very strong consensus on the latter but not the former.

Squashed to one commit in 044bef6 , will merge very shortly unless there are objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential update to fidelity bond settings
1 participant