Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic listing of livechat settings #352

Merged
merged 30 commits into from
May 28, 2024
Merged

Dynamic listing of livechat settings #352

merged 30 commits into from
May 28, 2024

Conversation

Murazaki
Copy link
Collaborator

@Murazaki Murazaki commented Apr 9, 2024 •
edited
Loading

Description

This is still a draft, will update when I have a more functional version.

Related issues

Mandatory Checks

  • I have added a description of the changes in the CHANGELOG files
  • I have run npm run lint to check that my changes respects the coding conventions
  • I have added user documentation for the new features I added
  • I have added technical documentation for the new features I added
  • I added some documentation and I have run npm run doc:translate to generate translations files

Screenshots

@Murazaki Murazaki changed the title [Draft] Attempt at making a dynamic listing of livechat settings [WIP] Attempt at making a dynamic listing of livechat settings Apr 9, 2024
@JohnXLivingston JohnXLivingston marked this pull request as draft April 11, 2024 09:58
@Murazaki Murazaki force-pushed the feature/dynamic-settings-list branch 3 times, most recently from 643dfbe to d524b54 Compare May 14, 2024 12:59
@Murazaki Murazaki force-pushed the feature/dynamic-settings-list branch from d524b54 to 57094a4 Compare May 23, 2024 00:26
JohnXLivingston
JohnXLivingston reviewed May 23, 2024
View reviewed changes
Copy link
Owner

@JohnXLivingston JohnXLivingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good work. Thanks a lot for your help!

client/common/configuration/register.ts Outdated Show resolved Hide resolved
client/common/configuration/templates/ChannelConfigurationElement.ts Outdated Show resolved Hide resolved
client/common/configuration/templates/TranslationDirective.ts Outdated Show resolved Hide resolved
client/common/configuration/templates/ChannelConfigurationService.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
client/common/configuration/templates/HelpButtonElement.ts Outdated Show resolved Hide resolved
client/common/configuration/templates/PluginConfigurationRow.ts Outdated Show resolved Hide resolved
client/common/configuration/templates/TranslationDirective.ts Outdated Show resolved Hide resolved
client/tsconfig.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@Murazaki Murazaki force-pushed the feature/dynamic-settings-list branch from cfdd616 to 3a062dc Compare May 23, 2024 14:16
@Murazaki Murazaki changed the title [WIP] Attempt at making a dynamic listing of livechat settings Dynamic listing of livechat settings May 23, 2024
@JohnXLivingston JohnXLivingston self-requested a review May 28, 2024 10:01
@JohnXLivingston JohnXLivingston marked this pull request as ready for review May 28, 2024 10:01
JohnXLivingston
JohnXLivingston requested changes May 28, 2024
View reviewed changes
Copy link
Owner

@JohnXLivingston JohnXLivingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work !
I let you see the 3 review comment i added, then rebase.
Don't forgot to add a changelog entry describing your work (and giving you credit for it).

package.json Outdated Show resolved Hide resolved
client/common/configuration/services/channel-details.ts Show resolved Hide resolved
Murazaki and others added 18 commits May 28, 2024 13:43
@Murazaki
added attempt at dynamic listing
9ff4abf
@Murazaki
Begin integrating components with lit
2638e13
@Murazaki
Adding some LitElements including DynamicTableFormElement
0fe9fb4
@Murazaki
Using ChannelConfigurationElement + Adding TranslationDirective
9ea26df 
and a lots of fixes
@Murazaki
Technically working options. Need CSS fix (plugin CSS not loaded) and…
687c474 
… data validation
@Murazaki
Better structure + channel home in LitElement format
de974ea
@Murazaki
Fixing ShadowDOM situation with CSS
fb3a5d2
@Murazaki
Fix button style
0491539
@JohnXLivingston @Murazaki
Cleaning some stuff.
b72b23d
@JohnXLivingston @Murazaki
Cleaning more stuff.
1d14bbb
@JohnXLivingston @Murazaki
REUSE compliance.
732f7ae
@JohnXLivingston @Murazaki
REUSE compliance.
5c46288
@JohnXLivingston @Murazaki
Fix
59825a1
@JohnXLivingston @Murazaki
package lock
afec3d9
@JohnXLivingston @Murazaki
Typescript and lit version change + fix form submit.
0672dc2
@Murazaki
update css handling on dynamic table form
5ef429e
@Murazaki
Several fixes around channel configuration
f549142
@Murazaki
fix linting
fb7f446
@Murazaki Murazaki force-pushed the feature/dynamic-settings-list branch from f87a151 to c5a3d8f Compare May 28, 2024 11:47
@JohnXLivingston JohnXLivingston self-requested a review May 28, 2024 12:04
@JohnXLivingston JohnXLivingston merged commit c5a3d8f into JohnXLivingston:main May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnXLivingston JohnXLivingston JohnXLivingston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Murazaki @JohnXLivingston