Skip to content

Commit

Permalink
fix(api): API calls were broken due to abstract method
Browse files Browse the repository at this point in the history
The class `ScheduleWebServiceView` had an abstract method
`BindViewableResourceReservation` which was not implemented. This
caused API access to fail with an error like:
    [php:error] [pid 84] [client 10.89.0.25:59502] PHP Fatal error:  Class ScheduleWebServiceView contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (ISchedulePage::BindViewableResourceReservations) in /var/www/html/WebServices/SchedulesWebService.php on line 169

Implement the missing method as a `no-op` method.

Closes: LibreBooking#343
  • Loading branch information
JohnVillalovos committed May 13, 2024
1 parent 2c48af2 commit ab89c7e
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions WebServices/SchedulesWebService.php
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,11 @@ public function BindScheduleAvailability($availability, $tooEarly)
$this->available = false;
}

public function BindViewableResourceReservations($resourceIds)
{
// no-op
}

public function SetAllowConcurrent($allowConcurrentReservations)
{
$this->allowConcurrentReservations = $allowConcurrentReservations;
Expand Down

0 comments on commit ab89c7e

Please sign in to comment.