Skip to content
This repository has been archived by the owner on Jun 18, 2019. It is now read-only.

Move to Swift Tools 4.2 #233

Merged
merged 3 commits into from
Feb 9, 2019
Merged

Conversation

orta
Copy link
Contributor

@orta orta commented Dec 21, 2018

This is the last warning I get with danger swift now 👍

Running swift test:

screen shot 2018-12-21 at 12 48 03 pm

@orta
Copy link
Contributor Author

orta commented Jan 23, 2019

Closing this in favor of #235 which is green, can we get a release with that John? Or add me and I'l do it 👍

Fixed source file references in Xcode project
@orta orta reopened this Jan 23, 2019
@orta
Copy link
Contributor Author

orta commented Jan 23, 2019

Re-opening it because @jagreenwood fixed this

@jagreenwood
Copy link
Contributor

#235 appears to update the Swift version in Xcode, which may not help get rid of the pesky PackageDescription API v3 is deprecated and will be removed in the future; used by package(s): Unbox warning.

This PR should deal with that 😄

Copy link
Owner

@JohnSundell JohnSundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @orta! 👍

@JohnSundell
Copy link
Owner

And @jagreenwood too of course 😄

@JohnSundell JohnSundell merged commit 4f6495f into JohnSundell:master Feb 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants