Add <time> element #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majortom64
reviewed
Feb 17, 2023
JohnSundell
requested changes
Mar 31, 2023
There was a problem hiding this comment.
Thanks for this @harrydayexe, and very sorry for taking so long to review this PR! I left a suggestion inline, which I think might simplify the implementation quite a bit (and make it easier to maintain). Let me know what you think.
JohnSundell
added
the
awaiting update
This is to remvove a dependecy on Foundation for a DateFormatter and to enable the user to select what kind of format they wish to select due to the multitude of formats available
JohnSundell
requested changes
Apr 21, 2023
There was a problem hiding this comment.
Thanks for updating your PR, @harrydayexe! I just have a few more pieces of feedback in order to make this change fully mergable. Let me know if I can help out in any way.
Removed Foundation imports and unneeded HTMLDateTimeContext as well as fixed some code style issues
|
Hopefully those changes are everything you spotted! |
JohnSundell
removed
the
awaiting update
JohnSundell
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick implementation of the
<time>element.Reference: https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-time-element