Add a new Component-based API and a much more flexible rendering system #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor Plot's rendering system to become much more flexible, by replacing the previous `ElementRenderer` class with a new, general-purpose `Renderer` struct, and by refactoring the `Node` enum into a struct that carries a free-form `rendering` closure. All of these changes are pure refactors - they don't affect the public API at all. - Add a new `Component` API that enables HTML `<body>` components to be defined in a very SwiftUI-like way. The new API ships with lots of built-in implementations that map to commonly used elements (such as `div`, `a`, `ul`, and so on), and enables the API user to easily define their own components as well. It also features an environment API (similar to the one that SwiftUI offers), the ability to apply modifiers to components, and complete interoperability with the existing `Node`-based API. - All of these changes are completely additive and fully backward compatible with the old API. The only potential situation that could cause these changes to be breaking for an API user is if a `Node` value was being switched on. Since it's now no longer an enum, that will no longer work, but it's highly unlikely that Plot's API has been used this way by any API user. - Update the documentation for the new `Component` API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ElementRendererclass with a new, general-purposeRendererstruct, and by refactoring theNodeenum into a struct that carries a free-formrenderingclosure. All of these changes are pure refactors - they don't affect the public API at all.ComponentAPI that enables HTML<body>components to be defined in a very SwiftUI-like way. The new API ships with lots of built-in implementations that map to commonly used elements (such asdiv,a,ul, and so on), and enables the API user to easily define their own components as well. It also features an environment API (similar to the one that SwiftUI offers), the ability to apply modifiers to components, and complete interoperability with the existingNode-based API.Nodevalue was being switched on. Since it's now no longer an enum, that will no longer work, but it's highly unlikely that Plot's API has been used this way by any API user.ComponentAPI.