Add support for the <object> tag #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a new `HTMLLinkableDataContext`. Include `testObject()` and pass successfully.
JohnSundell
reviewed
Apr 29, 2020
JohnSundell
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
@AlexLike I'm incredibly sorry for not re-reviewing your PR until now. It looks like a great addition to Plot, so I just resolved the conflicts with master and will merge it in once CI passes. Thanks a lot for contributing to Plot, and once again, I'm very sorry for taking literally years to review this PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<object>tag is a common way to include external SVG-files while preserving interactivity.This request adds support for the
<object>tag and itsdata: URLattribute with a newHTMLLinkableDataContext(becausedata(named name: String, value: String) -> Nodecouldn't accommodate the spec).testObject()passes successfully.(This is my first open-source PR, by the way. I hope everything goes as planned.)