Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARKNLP-620 Provide GCP Support for Cache Folder #13141

Conversation

danilojsl
Copy link
Contributor

Description

Adding support to use GCP Storage as a cache folder for pre-trained models.

Motivation and Context

Check issue #12792

How Has This Been Tested?

  • Local Tests
  • Google Colab notebooks

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danilojsl danilojsl added the new-feature Introducing a new feature label Nov 24, 2022
@maziyarpanahi maziyarpanahi added the DON'T MERGE Do not merge this PR label Nov 26, 2022
@maziyarpanahi maziyarpanahi self-assigned this Nov 26, 2022
@maziyarpanahi maziyarpanahi changed the base branch from master to feature/424-release-candidate November 28, 2022 10:08
@maziyarpanahi maziyarpanahi linked an issue Nov 28, 2022 that may be closed by this pull request
@maziyarpanahi maziyarpanahi merged commit 09f369e into feature/424-release-candidate Nov 28, 2022
@KshitizGIT KshitizGIT deleted the feature/SPARKNLP-620-provide-gcp-support-for-cache-folder branch March 2, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DON'T MERGE Do not merge this PR new-feature Introducing a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide GCS Support in cache_folder
2 participants