-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing base in normalize? #8
Comments
Hm, I just saw this closed issue: JohnAlbin/normalize.css-with-sass-or-compass#1 Still, I think it's not the responsibility of normalize to import this, but maybe I'm wrong. edit: here is a commit which remove this idflood@3074cd6 |
I've been re-thinking this point recently. While I still think using a base partial is important, given SMACSS' conflicting use of the term "base", I'm not sure Compass' should be recommending that particular name for the file anymore. So we should remove that line from normalize.scss. FYI, I now rename normalize.scss to _normalize.scss myself. Do we want to do that too? I'm uncertain. |
Ohh, good catch. Definitely +1 for renaming to _normalize.scss. This way it gives more flexibility and doesn't create a stylesheet for normalize if it's not needed. I think that if someone use the scss version of normalize then it is included in a screen.scss or something like that. If they want to include normalize.css and the theme.css separately in their theme, then using the original normalize.css is certainly easier. |
Thanks for your feedback! Fixed! |
Hi,
Thanks for this nice port of formalize. I have one question though, why do you import "base" in normalize? I think it would be better to leave it to the themer since "base" can be in other directory or even have a different name.
For instance, in my main.sass file I usually have something like:
The text was updated successfully, but these errors were encountered: