Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing base in normalize? #8

Closed
idflood opened this issue Nov 12, 2012 · 4 comments
Closed

Importing base in normalize? #8

idflood opened this issue Nov 12, 2012 · 4 comments

Comments

@idflood
Copy link

idflood commented Nov 12, 2012

Hi,

Thanks for this nice port of formalize. I have one question though, why do you import "base" in normalize? I think it would be better to leave it to the themer since "base" can be in other directory or even have a different name.

For instance, in my main.sass file I usually have something like:

@import global/base
@import vendor/normalize
@import partials/...
@idflood
Copy link
Author

idflood commented Nov 12, 2012

Hm, I just saw this closed issue: JohnAlbin/normalize.css-with-sass-or-compass#1

Still, I think it's not the responsibility of normalize to import this, but maybe I'm wrong.

edit: here is a commit which remove this idflood@3074cd6

@JohnAlbin
Copy link
Owner

I've been re-thinking this point recently. While I still think using a base partial is important, given SMACSS' conflicting use of the term "base", I'm not sure Compass' should be recommending that particular name for the file anymore. So we should remove that line from normalize.scss.

FYI, I now rename normalize.scss to _normalize.scss myself. Do we want to do that too? I'm uncertain.

@idflood
Copy link
Author

idflood commented Nov 20, 2012

Ohh, good catch. Definitely +1 for renaming to _normalize.scss. This way it gives more flexibility and doesn't create a stylesheet for normalize if it's not needed.

I think that if someone use the scss version of normalize then it is included in a screen.scss or something like that. If they want to include normalize.css and the theme.css separately in their theme, then using the original normalize.css is certainly easier.

@JohnAlbin
Copy link
Owner

Thanks for your feedback! Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants