New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly use KeyHandler type from hotkeys-js #243

Merged

JohannesKlauss merged 1 commit into JohannesKlauss:master from jameschao:jc/key-handler-type-from-hotkeys-js

Mar 27, 2020

Contributor

jameschao commented Mar 27, 2020

This PR uses the type declaration for KeyHandler directly from hotkeys-js, so the type is not duplicated here.

For background, I have a separate PR for hotkeys-js jaywcjlove/hotkeys-js#164 that updates the KeyHandler return type.


          Directly use KeyHandler type from hotkeys-js

f6d2f7c

Owner

JohannesKlauss commented Mar 27, 2020

@jameschao thank you very much for your contribution.

JohannesKlauss merged commit 6b549ce into JohannesKlauss:master

jameschao deleted the jc/key-handler-type-from-hotkeys-js branch

March 27, 2020 13:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet