temporary fix for Edge to build sass #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Sep 28, 2018
| @@ -1,3 +1,15 @@ | |||
| // Temporary fix from: https://github.com/medialize/sass.js/issues/96#issuecomment-424386171 | |||
There was a problem hiding this comment.
Definitely don't like touching 3rd party files but it's your call, ultimately.
There was a problem hiding this comment.
I asked for a patch on the Sass.js repository so when they fixed that, we will be able to remove that
There was a problem hiding this comment.
I think we should do that at hot fix but temporary, because our customizer isn't working for Edge users 😟
There was a problem hiding this comment.
Oh, OK, if this is going to be fixed upstream.
There was a problem hiding this comment.
yep here: medialize/sass.js#96 (comment) 👍
XhmikosR
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #35