Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinity fix and clang from PPA #2

Conversation

daschuer
Copy link

@daschuer daschuer commented Nov 8, 2024

No description provided.

Copy link

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

introducing util_*_infinity still opening a hellscape to undefined behavior...

Comment on lines +53 to +55
float util_float_infinity() {
return std::numeric_limits<double>::infinity();
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
float util_float_infinity() {
return std::numeric_limits<double>::infinity();
}
float util_float_infinity() {
return std::numeric_limits<float>::infinity();
}

@JoergAtGithub
Copy link
Owner

@daschuer Thank you very much for setting up the Clazy PPA! I cherry-picked this into mixxxdj#13781
But I will not do the same for the commit with the inifinity fix. This is because:
1.) This would be an unrelated scope expansion of my PR
2.) As written 3 weeks ago in mixxxdj#13780, there is no consensus about the fplcassify approach in general. The expected discussion would uneccessarily delay my PR.
3.) If we agree on a fix, this should go into the stable branch, as this is also affected

Therefore please create an independent PR against 2.4, where we can discuss this fix seperately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants