-
-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include native-image files correctly #784
Conversation
WalkthroughWalkthroughThe changes made to the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderabbitai Why do you say that "The file reflect-config.json is not correctly copied from META-INF/native-image to target"? |
Tip For best results, initiate chat on the files or code changes. @jodastephen The reason for the statement is that there were no existing configurations in the Analysis chainScripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Search for any existing configurations in the pom.xml file that handle the copying of files from META-INF/native-image to the target directory.
rg 'META-INF/native-image' -A 5 --glob '**/pom.xml'
Length of output: 51 Script: #!/bin/bash
# Search for any references to reflect-config.json in the pom.xml file.
rg 'reflect-config.json' --glob '**/pom.xml'
Length of output: 44 |
967a5ef
to
68ee5c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jodastephen changes are made and force pushed as a single commit to merge them directly. 👍 |
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [joda-time:joda-time](https://www.joda.org/joda-time/) ([source](https://redirect.github.com/JodaOrg/joda-time)) | `2.12.7` -> `2.13.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/joda-time:joda-time/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/joda-time:joda-time/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/joda-time:joda-time/2.12.7/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/joda-time:joda-time/2.12.7/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>JodaOrg/joda-time (joda-time:joda-time)</summary> ### [`v2.13.0`](https://redirect.github.com/JodaOrg/joda-time/releases/tag/v2.13.0) [Compare Source](https://redirect.github.com/JodaOrg/joda-time/compare/v2.12.7...v2.13.0) See the [change notes](https://www.joda.org/joda-time/changes-report.html#a2.13.0) for more information. #### What's Changed - Make `ConverterManager.getInstance()` init thread-safe. by [@​cpovirk](https://redirect.github.com/cpovirk) in [https://github.com/JodaOrg/joda-time/pull/776](https://redirect.github.com/JodaOrg/joda-time/pull/776) - Add website page about secutity/CVEs by [@​jodastephen](https://redirect.github.com/jodastephen) in [https://github.com/JodaOrg/joda-time/pull/781](https://redirect.github.com/JodaOrg/joda-time/pull/781) - fix: include native-image files correctly by [@​klopfdreh](https://redirect.github.com/klopfdreh) in [https://github.com/JodaOrg/joda-time/pull/784](https://redirect.github.com/JodaOrg/joda-time/pull/784) - Enhance TZDB compiler to better match spec by [@​jodastephen](https://redirect.github.com/jodastephen) in [https://github.com/JodaOrg/joda-time/pull/786](https://redirect.github.com/JodaOrg/joda-time/pull/786) - Update GitHub actions to latest versions by [@​jodastephen](https://redirect.github.com/jodastephen) in [https://github.com/JodaOrg/joda-time/pull/788](https://redirect.github.com/JodaOrg/joda-time/pull/788) - Fix TZDB compiler %z parsing by [@​jodastephen](https://redirect.github.com/jodastephen) in [https://github.com/JodaOrg/joda-time/pull/787](https://redirect.github.com/JodaOrg/joda-time/pull/787) - Update tzdb handling by [@​jodastephen](https://redirect.github.com/jodastephen) in [https://github.com/JodaOrg/joda-time/pull/789](https://redirect.github.com/JodaOrg/joda-time/pull/789) - Update time zone data to 2024bgtz by [@​github-actions](https://redirect.github.com/github-actions) in [https://github.com/JodaOrg/joda-time/pull/790](https://redirect.github.com/JodaOrg/joda-time/pull/790) #### New Contributors - [@​cpovirk](https://redirect.github.com/cpovirk) made their first contribution in [https://github.com/JodaOrg/joda-time/pull/776](https://redirect.github.com/JodaOrg/joda-time/pull/776) - [@​klopfdreh](https://redirect.github.com/klopfdreh) made their first contribution in [https://github.com/JodaOrg/joda-time/pull/784](https://redirect.github.com/JodaOrg/joda-time/pull/784) **Full Changelog**: JodaOrg/joda-time@v2.12.7...v2.13.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/camunda/camunda). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIl19-->
Fixes: #783
Hint: I added a new resource block with **/*.json as there may also be a reflect-config.json in future which might also be included.
Test result:
Summary by CodeRabbit
Summary by CodeRabbit
These changes enhance project documentation and improve resource handling without affecting existing functionality.