Change currency for ZW to ZWG #142
Conversation
WalkthroughWalkthroughThe update introduces version 1.0.5 of the currency definitions XML file in line with the ISO 4217 currency standard. Key changes include the modification of Zimbabwe's currency code from ZWL to ZWG, and the specification that the currency symbol for 'XXX' will return 'XXX' when using Java 21. Additionally, previous release entries have been updated to include ISO amendment references for enhanced clarity regarding currency changes. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Application
participant CurrencyService
User->>Application: Request currency symbol for 'XXX'
Application->>CurrencyService: Fetch currency symbol
CurrencyService-->>Application: Return 'XXX'
Application-->>User: Display currency symbol 'XXX'
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
src/main/resources/org/joda/money/CountryData.csvis excluded by!**/*.csvsrc/main/resources/org/joda/money/CurrencyData.csvis excluded by!**/*.csv
Files selected for processing (1)
- src/changes/changes.xml (3 hunks)
Additional comments not posted (5)
src/changes/changes.xml (5)
11-11: Verify the SNAPSHOT status for version 1.0.5.The release entry for version 1.0.5 is marked as SNAPSHOT. Ensure that this status is appropriate and update the date before final release.
12-13: Ensure consistency of ZW currency code update.The currency code for Zimbabwe has been updated from ZWL to ZWG. Verify that this change is consistently applied throughout the codebase.
15-17: Verify the update for currency symbol 'XXX'.The currency symbol for 'XXX' is set to return 'XXX' on Java 21. Ensure that this update is correctly implemented and tested for consistency.
32-32: ISO amendment reference for HRK to EUR change is accurate.The addition of ISO 4217 Amendment 174 reference for the HRK to EUR change enhances clarity and traceability.
45-45: ISO amendment reference for SLL to SLE change is accurate.The addition of ISO 4217 Amendment 171 reference for the SLL to SLE change enhances clarity and traceability.
ISO 4217 Amendment 177
Summary by CodeRabbit
New Features
Bug Fixes
Documentation