Add IconImageView and IconImageButton #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although single icons can be rendered as text in text views, it requires setting a fixed size. Using a drawable allows it to automatically scale according to the size of the widget. Therefore, this commit introduces IconImageView and IconImageButton to enable using the drawable in XML. They also define custom attributes for the icon properties, which improves readability and extendibility. Furthermore, extending ImageView and ImageButton provides easy inoperability with other drawables (i.e when switching between XML drawable resources and IconDrawable).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although single icons can be rendered as text in text views, it requires setting a fixed size. Using a drawable allows it to automatically scale according to the size of the widget. Therefore, this pull request introduces
IconImageViewandIconImageButtonto enable using the drawable in XML. They also define custom attributes for the icon properties, which improves readability and extendibility. Furthermore, extendingImageViewandImageButtonprovides easy inoperability with other drawables (i.e when switching between XML drawable resources andIconDrawable).Resolves #132