Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Scroll to top in about and contact us #348

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

sakshii00
Copy link
Contributor

@sakshii00 sakshii00 commented May 20, 2024

Title and Issue number

Title : Scroll to top functionality

Issue No. : #339

Closes #339

Changes Made

I added scroll to top for both about and contact us in footer.

BEFORE

issue.mp4

AFTER

solve.mp4

Checklist

  • I have tested these changes locally.
  • I have reviewed the code and ensured it follows the project's coding standards.

now clicking about and contact us in footer scrolls it to top.
Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shop-nex ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 7:52am

@sakshii00
Copy link
Contributor Author

@ivedmohan @Vansh-Choudhary please review and merge.

@sakshii00
Copy link
Contributor Author

@ivedmohan @Vansh-Choudhary any updates ?

Copy link
Collaborator

@Vansh-Choudhary Vansh-Choudhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved !

@Sushilverma002 Sushilverma002 merged commit 8b7dad9 into JiyaGupta-cs:master Jun 21, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About and contact us in footer on clicking doesn't scroll to top
3 participants