merge

.github/comment.yml

@@ -39,7 +39,7 @@
 - rule:
     type: label
     label: NewApiVersionRequired
-    onLabeledComments: "<b>NewApiVersionRequired reason:</b></br> </br><b>A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support. </b> </br></br> EXAMPLE: if a customer calls a service in the public cloud using <b>api-version=2020-07-27</b>, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.  "
+    onLabeledComments: "The automation detected this Pull Request introduces breaking changes to an existing API version and hence it added the <code>NewApiVersionRequired</code> label. This means you cannot proceed with merging this PR until you complete one of the following action items:<br/><br/>- A) Submit a new PR instead of this one, or modify this PR, so that it introduces a new API version instead of introducing breaking changes to an existing API version. The automation will remove the label once it detects there are no more breaking changes.<br/>- B) OR you can request an approval of the breaking changes, get it reviewed, and approved. The reviewer will add <code>Approved-BreakingChange</code> label if they approve.<br/><br/>For additional guidance, please see https://aka.ms/NewApiVersionRequired<br/>  "
 
 - rule:
     type: label

CODEOWNERS

@@ -50,7 +50,7 @@
 /specification/azsadmin/ @deathly809
 
 # PRLabel: %Batch
-/specification/batch/ @paterasMSFT @dpwatrous
+/specification/batch/ @jingjlii @paterasMSFT @dpwatrous
 
 # PRLabel: %BatchAI
 /specification/batchai/ @alexanderyukhanov
@@ -219,7 +219,7 @@
 /specification/servicefabric/ @juhacket @samedder
 
 # PRLabel: %SQL
-/specification/sql/ @jamestao @ericshape
+/specification/sql/ @jamestao @ericshape @jeremyfrosti
 
 # PRLabel: %Storage
 /specification/storage/ @jasonyang-msft

arm-compute/quickstart-templates/aliases.json

@@ -86,6 +86,13 @@
             "version": "latest",
             "architecture": "x64"
           },
+          "SuseSles15SP3": {
+            "publisher": "SUSE",
+            "offer": "sles-15-sp3",
+            "sku": "gen2",
+            "version": "latest",
+            "architecture": "x64"
+          },
           "UbuntuLTS": {
             "publisher": "Canonical",
             "offer": "UbuntuServer",

cSpell.json

@@ -917,6 +917,15 @@
                 "Transliterable",
                 "translitered"
             ]
+        },
+        {
+            "filename": "**/specification/fist/resource-manager/Microsoft.IoTFirmwareDefense/preview/**/*.json",
+            "words": [
+                "RELRO",
+                "relro",
+                "rpath",
+                "runpath"
+            ]
         }
     ],
     "enableFiletypes": [

custom-words.txt

@@ -130,6 +130,7 @@ API's
 apiserver
 apitoken
 apiview
+apms
 APNIC
 APNS
 appconfig
@@ -411,6 +412,7 @@ Cmek
 CMKDW
 CMKHS
 CMMI
+CMWIs
 CNAME
 cnames
 CODEGEN
@@ -556,6 +558,7 @@ DBFS
 DCOS
 DCSPM
 ddagpu
+DDDS
 Ddos
 DDTHH
 deadletter
@@ -651,6 +654,10 @@ Distro
 DMARC
 DMTS
 Dnat
+DNSKEY
+dnssec
+Dnssec
+DNSSEC
 dnsname
 dnszones
 DOCM
@@ -742,6 +749,7 @@ eventhubconnections
 eventhubs
 eventroutes
 eventstream
+eventsubscriptions
 eventtime
 eventtypes
 evpn
@@ -1166,6 +1174,7 @@ legalhold
 Lfot
 LHCP
 Lhcp
+libgit
 libtrust
 lifecycle
 lifecycles
@@ -1366,6 +1375,8 @@ MSLISTSTATUS
 MSMCAZR
 msrp
 MSTI
+Mtls
+mtls
 mucho
 multiapi
 Multiclass
@@ -1403,6 +1414,7 @@ mypictures
 myregistry
 myshopify
 mysite
+mysolutions
 mysquare
 mystore
 myvolume
@@ -2238,6 +2250,8 @@ Timespan
 timestep
 timezones
 tinyint
+Tlsa
+TLSA
 Tokenizes
 tombstoned
 toolset
@@ -2382,9 +2396,12 @@ versionid
 Vertica
 Vfyc
 vhds
+vhdx
 videosearch
 viewp
 vippool
+virutal
+Virutal
 virtualclusters
 virtualharddisks
 virtualip

documentation/ci-fix.md

@@ -31,10 +31,17 @@ npm install
 # Compile TypeScript. Compilation will fail, this is expected. But it will compile 'scripts/prettier-swagger-plugin', which is what we need.
 npx tsc 
 
-# Run 'prettier --list-different' to understand what is the problem.
+# As of 5/25/2023, the prettier version should be 2.1.2
+npx prettier --version
+
+# Run 'prettier --check' to verify the problems can be reproduced locally
+npx prettier --check **/*.json
+
+# Run 'prettier --list-different' to understand which files have problems.
+# Note: there is no way to view the exact problems without actually changing the affected files. See https://github.com/prettier/prettier/issues/6069.
 npx prettier --list-different **/*.json
 
-# Run 'prettier --write' to fix the problem.
+# Run 'prettier --write' to fix the problems.
 npx prettier --write **/*.json
 ```
 

eng/pipelines/typespec-ci.yml

@@ -12,7 +12,7 @@ pr:
     - package.json
     - package-lock.json
     - eng/pipelines/typespec-ci.yml
-    - eng/pipelines/templates/specs/typespec-ci.yml
+    - eng/pipelines/templates/steps/typespec-ci.yml
 
 jobs:
 - job: TypeSpecCI
@@ -23,7 +23,10 @@ jobs:
   steps:
   - script: npm ci
     displayName: npm ci
-
+
+  - script: npm ls -a
+    displayName: npm ls -a
+
   - template: templates/steps/typespec-ci.yml
     parameters:
       Folder: specification/contosowidgetmanager/Contoso.WidgetManager
@@ -49,6 +52,16 @@ jobs:
       Folder: specification/cognitiveservices/OpenAI.Inference
       DisplayName: OpenAI.Inference
 
+  - template: templates/steps/typespec-ci.yml
+    parameters:
+      Folder: specification/containerservice/Fleet.Management
+      DisplayName: Fleet.Management
+
+  - template: templates/steps/typespec-ci.yml
+    parameters:
+      Folder: specification/servicenetworking/ServiceNetworking.Management
+      DisplayName: Microsoft.ServiceNetworking
+
   - template: templates/steps/typespec-ci.yml
     parameters:
       Folder: specification/translation/Azure.AI.TextTranslation

package.json

@@ -7,8 +7,8 @@
     "@azure-tools/cadl-azure-resource-manager": "0.26.0",
     "@azure-tools/cadl-providerhub": "0.26.0",
     "@azure-tools/typespec-apiview": "0.4.4",
-    "@azure-tools/typespec-autorest": "0.30.0",
-    "@azure-tools/typespec-azure-core": "0.30.0",
+    "@azure-tools/typespec-autorest": "0.30.1",
+    "@azure-tools/typespec-azure-core": "0.30.1",
     "@azure-tools/typespec-azure-resource-manager": "0.30.0",
     "@azure-tools/typespec-providerhub": "0.30.0",
     "@typespec/compiler": "0.44.0",

specification/advisor/resource-manager/Microsoft.Advisor/stable/2023-01-01/examples/CreateConfiguration.json

@@ -31,7 +31,7 @@
   "responses": {
     "200": {
       "body": {
-        "id": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Advisor/configurations/default",
+        "id": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Advisor/configurations/v2/default",
         "type": "Microsoft.Advisor/configurations",
         "name": "default",
         "properties": {

specification/app/resource-manager/Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json

@@ -594,11 +594,11 @@
       "type": "object",
       "properties": {
         "destination": {
-          "description": "Logs destination",
+          "description": "Logs destination, can be 'log-analytics', 'azure-monitor' or 'none'",
           "type": "string"
         },
         "logAnalyticsConfiguration": {
-          "description": "Log Analytics configuration",
+          "description": "Log Analytics configuration, must only be provided when destination is configured as 'log-analytics'",
           "$ref": "#/definitions/LogAnalyticsConfiguration"
         }
       }
@@ -758,7 +758,7 @@
       }
     },
     "LogAnalyticsConfiguration": {
-      "description": "Log analytics configuration",
+      "description": "Log Analytics configuration, must only be provided when destination is configured as 'log-analytics'",
       "type": "object",
       "properties": {
         "customerId": {

specification/app/resource-manager/Microsoft.App/preview/2022-06-01-preview/ManagedEnvironments.json

@@ -779,11 +779,11 @@
       "type": "object",
       "properties": {
         "destination": {
-          "description": "Logs destination",
+          "description": "Logs destination, can be 'log-analytics', 'azure-monitor' or 'none'",
           "type": "string"
         },
         "logAnalyticsConfiguration": {
-          "description": "Log Analytics configuration",
+          "description": "Log Analytics configuration, must only be provided when destination is configured as 'log-analytics'",
           "$ref": "#/definitions/LogAnalyticsConfiguration"
         }
       }
@@ -971,7 +971,7 @@
       }
     },
     "LogAnalyticsConfiguration": {
-      "description": "Log analytics configuration",
+      "description": "Log Analytics configuration, must only be provided when destination is configured as 'log-analytics'",
       "type": "object",
       "properties": {
         "customerId": {

specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json

@@ -1049,11 +1049,11 @@
       "type": "object",
       "properties": {
         "destination": {
-          "description": "Logs destination",
+          "description": "Logs destination, can be 'log-analytics', 'azure-monitor' or 'none'",
           "type": "string"
         },
         "logAnalyticsConfiguration": {
-          "description": "Log Analytics configuration",
+          "description": "Log Analytics configuration, must only be provided when destination is configured as 'log-analytics'",
           "$ref": "#/definitions/LogAnalyticsConfiguration"
         }
       }
@@ -1267,7 +1267,7 @@
       }
     },
     "LogAnalyticsConfiguration": {
-      "description": "Log analytics configuration",
+      "description": "Log Analytics configuration, must only be provided when destination is configured as 'log-analytics'",
       "type": "object",
       "properties": {
         "customerId": {