error: you seem to want to iterate on a map's values --> rust/ommx/src/evaluate.rs:428:25 | 428 | for (_id, d) in &mut self.decision_variable_dependency { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map = note: `-D clippy::for-kv-map` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::for_kv_map)]` help: use the corresponding method | 428 | for d in self.decision_variable_dependency.values_mut() { | ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashMap` --> rust/ommx/src/evaluate.rs:505:43 | 505 | let mut bucket: Vec<_> = dependencies.into_iter().collect(); | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref = note: `-D clippy::into-iter-on-ref` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::into_iter_on_ref)]`

error: this expression creates a reference which is immediately dereferenced by the compiler --> rust/ommx/src/evaluate.rs:511:30 | 511 | match f.evaluate(&state) { | ^^^^^^ help: change this to: `state` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`