Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated steps to set firewall rules for AWS and attached 3 more 'X' to 'outline_logXXX' #1386

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updated steps to set firewall rules for AWS and attached 3 more 'X' to 'outline_logXXX' #1386

wants to merge 3 commits into from

Conversation

QingXXiong
Copy link

This pull request:

  1. Updated steps to set firewall rules for AWS, for #Update instructions for setting up firewall rules on AWS  outline-apps#1858.
  2. Attached 3 more 'X' to 'outline_logXXX' for temporary filenames on OpenBSD, for #Insufficient number of Xs in template 'outline_logXXX' when installing on Open BSD server #1234.

@QingXXiong
Updated steps to set up firewall rules for AWS in 'en.json'
acd82c7 
Attached 'XXX' to 'outline_logXXX' in 'install_server.sh'
@QingXXiong QingXXiong requested a review from a team as a code owner August 10, 2023 03:44
daniellacosse
daniellacosse reviewed Aug 10, 2023
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
fortuna
fortuna reviewed Aug 10, 2023
View reviewed changes
src/server_manager/messages/en.json
"aws-lightsail-firewall-3": "In the 'Firewall' section, click 'Add another'.",
"aws-lightsail-firewall-4": "Set 'Application' value to 'All TCP+UDP'.",
"aws-lightsail-firewall-5": "Click 'Save'.",
"aws-lightsail-firewall-3": "Scroll down to 'IPv6 firewall', then click 'Add rule'.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about IPv4?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS'll auto-create the same rules for IPv4 by default.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other ways also exist for setting up the rule, but I believe these steps are quick and easy.

@QingXXiong
Fix the version value in package-lock.json
04855fe 
Fix the version value, probably changed because of local build.
@QingXXiong
Update package-lock.json
852b9b7 
Refixed the extra quotes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellacosse daniellacosse daniellacosse left review comments

@fortuna fortuna fortuna left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QingXXiong @fortuna @daniellacosse