Cannot switch back to English after chose another language

[jyyi1]

Describe the bug
In the web-app, after I chose a language other than English and refresh the page, I can not switch back to English.

To Reproduce

1. "Navigation Button" -> "Change Language" -> "Español"
2. Refresh the page
3. The language is in Spanish (which is expected)
4. "Navigation Button" -> "Cambiar idioma" -> "English"
5. Nothing happens, refreshing does not help either

There are at least three problems:

1. The "Change Language" title is "language-page-title"
2. After choose "English", nothing happens, and the language is still in Spanish
3. Fake Server for local development are gone
4. This applies to all languages other than English

Workaround
Delete "overrideLanguage" field in the local storage.

Expected behavior
I should be able to switch back to English and all features should be normal.

Screenshots
N/A

Client System (please complete the following information):

• Outline Client Version: local development
• Your Operating System: MacOS

Additional context

Uncaught (in promise) Error: The intl string context variable 'mediumUrl' was not provided to the string 'Outline es un proyecto de código abierto que <a href={jigsawUrl}>Jigsaw</a> creó para que los periodistas y las organizaciones de noticias tengan una forma más segura de acceder a Internet.<br><br> Outline es un producto que cuenta con la tecnología de <a href={shadowsocksUrl}>Shadowsocks</a> y que aún se encuentra en una etapa inicial. Puedes colaborar con el código en <a href={gitHubUrl}>GitHub</a> y seguirnos en <a href={redditUrl}>Reddit</a> y <a href={mediumUrl}>Medium</a> para estar al tanto cuando nos expandamos a más plataformas y agreguemos nuevas funciones.'
    at MessageFormat.format (core.js:48)
    at HTMLElement.<anonymous> (app-localize-behavior.js:291)
    at runMethodEffect (property-effects.js:1038)
    at Function._evaluateBinding (property-effects.js:3161)
    at Object.runBindingEffect [as fn] (property-effects.js:785)
    at runEffects (property-effects.js:140)
    at baseRunEffects (property-effects.js:1958)
    at HTMLElement._runEffectsForTemplate (property-effects.js:1967)
    at HTMLElement._propagatePropertyChanges (property-effects.js:1952)
    at HTMLElement._propertiesChanged (property-effects.js:1916)

[fortuna]

@jyyi1 What command did you use to run the client?

Also, what browser and version did you use?

[fortuna]

Oh, oh, this PR is the culprit: #1061

We are no longer passing the mediumUrl. However, we need to generate new translations. We only updated English.

THIS WILL BREAK THE CLIENT! We can't release in the current state. I'm pretty sure if you build and run the app from master it will be broken. The released client in production was not affected by that change. You can confirm by looking at the about message.

@bemasc can you show @jyyi1 (and @daniellacosse) how to update the translations?

[fortuna]

/cc @cjhenck

[fortuna]

On a side note, this is a really hard bug to catch. It could easily make it to production.

@daniellacosse @jyyi1 we need a way to type-check the messages. Perhaps convert the messages into actual TS code like we do at Google.

[daniellacosse]

Yes, I was just thinking about how easy it would be to catch a bug like this with a little more automation. I dunno how much appetite we have for that in the quarters to come but I would love to have some time allocated to testing and type coverage.

…

On Tue, Nov 16, 2021 at 11:27 AM Vinicius Fortuna ***@***.***> wrote: On a side note, this is a really hard bug to catch. It could easily make it to production. @daniellacosse <https://github.com/daniellacosse> @jyyi1 <https://github.com/jyyi1> we need a way to type-check the messages. Perhaps convert the messages into actual TS code like we do at Google. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1098 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4V5VDESQIAH2ZMOICBUADUMKA5JANCNFSM5H54AGLA> .

[jyyi1]

@fortuna @daniellacosse One solution I could think of is to compare resource string keys among all the languages, but I need to first make sure how the translation works.

[bemasc]

Unfortunately, we can't really require parity between languages as part of our compilation or presubmit CI, because we need to be able to update the UI before we have translations for new strings. However, we might be able to add a pre-release CI step that catches these issues.