Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attrsToString: To avoid some malformed attributes #26

Merged
merged 4 commits into from
Jun 27, 2019
Merged

attrsToString: To avoid some malformed attributes #26

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83a88b9
attrsToString: To avoid some malformed attributes
arkhamvm Jun 24, 2019
5406679
eslint
arkhamvm Jun 24, 2019
73ac325
Update index.js
arkhamvm Jun 27, 2019
4a82a0b
Update index.test.js
arkhamvm Jun 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/bbob-plugin-helper/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,16 @@ const attrValue = (name, value) => {
* Transforms attrs to html params string
* @param values
*/
const attrsToString = values =>
Object.keys(values)
const attrsToString = (values) => {
// To avoid some malformed attributes
if (undefined === values) {
arkhamvm marked this conversation as resolved.
Show resolved Hide resolved
return '';
}

return Object.keys(values)
.reduce((arr, key) => [...arr, attrValue(key, values[key])], [''])
.join(' ');
};

export {
attrsToString,
Expand Down