-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add start and end positions of tag nodes #246
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3af485a The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Improves accuracy of row/col error reporting. Now targets the start of the relevant token instead of the end.
Good work! I will check it later 👍 |
JiLiZART
reviewed
Jul 29, 2024
JiLiZART
reviewed
Jul 29, 2024
JiLiZART
reviewed
Jul 31, 2024
JiLiZART
reviewed
Jul 31, 2024
All looks good for me! 👍 |
improve readability of end pos offset for no attr tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds start and end position of the start/end of tag nodes. This gives developers more control in debugging issues. This also allows developers to perform manual string manipulation beyond the limitations of the parser.
'[bar]Foo Bar[/bar]'
will parse to:
An example of string manipulation usage
parses to:
Since quotes was not used and there is a single integer by itself, recovering the original full single value would be impossible without using string manipulation.
Improves accuracy of row/col error reporting. Now targets the start of the relevant token instead of the end.
Closes #134
Edit: Update description to reflect simpler language