Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: typescript support #185

Merged
merged 63 commits into from
Apr 23, 2024
Merged

feat: typescript support #185

merged 63 commits into from
Apr 23, 2024

Conversation

JiLiZART
Copy link
Owner

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 3c0940b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 18, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.19331% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 92.95%. Comparing base (05246b2) to head (583a6e6).

❗ Current head 583a6e6 differs from pull request most recent head 3c0940b. Consider uploading reports for the commit 3c0940b to get more accurate results

Files Patch % Lines
packages/bbob-html/src/index.ts 73.68% 9 Missing and 1 partial ⚠️
packages/bbob-preset/src/index.ts 63.63% 8 Missing ⚠️
packages/bbob-parser/src/parse.ts 96.15% 3 Missing and 2 partials ⚠️
packages/bbob-plugin-helper/src/helpers.ts 90.56% 5 Missing ⚠️
packages/bbob-core/src/utils.ts 91.66% 3 Missing ⚠️
packages/bbob-plugin-helper/src/TagNode.ts 94.44% 3 Missing ⚠️
packages/bbob-core/src/index.ts 94.44% 2 Missing ⚠️
packages/bbob-parser/src/Token.ts 91.30% 2 Missing ⚠️
packages/bbob-preset-html5/src/defaultTags.ts 96.72% 2 Missing ⚠️
packages/bbob-core/src/errors.ts 83.33% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   87.54%   92.95%   +5.41%     
==========================================
  Files          26       27       +1     
  Lines        1549      908     -641     
  Branches      371      208     -163     
==========================================
- Hits         1356      844     -512     
+ Misses        189       61     -128     
+ Partials        4        3       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JiLiZART JiLiZART force-pushed the feat/typescript-support branch from a490ed4 to 402edf4 Compare October 23, 2023 13:06
@JiLiZART JiLiZART added the P0 Critical Issue label Nov 14, 2023
@JiLiZART JiLiZART marked this pull request as draft November 14, 2023 07:18
@JiLiZART JiLiZART self-assigned this Nov 14, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 25, 2024
View reviewed changes
packages/bbob-cli/test/cli.test.ts Fixed Show fixed Hide fixed
packages/bbob-cli/test/cli.test.ts Fixed Show fixed Hide fixed
packages/bbob-cli/test/cli.test.ts Fixed Show fixed Hide fixed
packages/bbob-cli/test/cli.test.ts Fixed Show fixed Hide fixed
@JiLiZART JiLiZART linked an issue Mar 27, 2024 that may be closed by this pull request
Is there any plan for TypeScript supporting? #89
Closed
JiLiZART added 5 commits March 27, 2024 03:41
@JiLiZART
Merge remote-tracking branch 'origin/master' into feat/typescript-sup…
d161762 
…port

# Conflicts:
#	.github/workflows/benchmark.yml
#	.github/workflows/publish.yml
#	.github/workflows/test.yml
#	.gitignore
#	packages/bbob-react/src/render.js
#	pnpm-lock.yaml
@JiLiZART
refactor: rewrite pkg-task, add nx gen-types deps, fix react/render.ts
d1915b4
@JiLiZART
refactor: types
d7c2f04
@JiLiZART
fix: types
8be912d
@JiLiZART
fix: rename gen-types to types
72e1926
@JiLiZART JiLiZART marked this pull request as ready for review April 20, 2024 02:40
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 23, 2024
View reviewed changes
packages/bbob-cli/test/cli.test.ts Dismissed Show dismissed Hide dismissed
packages/bbob-cli/test/cli.test.ts Dismissed Show dismissed Hide dismissed
packages/bbob-cli/test/cli.test.ts Dismissed Show dismissed Hide dismissed
packages/bbob-cli/test/cli.test.ts Dismissed Show dismissed Hide dismissed
@JiLiZART JiLiZART merged commit 8797f7f into master Apr 23, 2024
6 checks passed
@JiLiZART JiLiZART deleted the feat/typescript-support branch April 23, 2024 19:11
@JiLiZART JiLiZART restored the feat/typescript-support branch April 23, 2024 19:12
JiLiZART added a commit that referenced this pull request Apr 23, 2024
@JiLiZART
Revert "feat: typescript support (#185)"
bb81aca 
This reverts commit 8797f7f.
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Merged
@JiLiZART JiLiZART deleted the feat/typescript-support branch September 11, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JiLiZART JiLiZART

Labels
P0 Critical Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is there any plan for TypeScript supporting?
1 participant
@JiLiZART