Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serious mobile view problems - near 0 editing space #368

Closed
vanillamasonry opened this issue May 10, 2020 · 3 comments
Closed

Serious mobile view problems - near 0 editing space #368

vanillamasonry opened this issue May 10, 2020 · 3 comments

Comments

@vanillamasonry
Copy link

vanillamasonry commented May 10, 2020

The buttons and the toolbars are too big, The editor is useless for mobile apps and sites. You must find another solution. The current solution is OK for desktop and tablets

And another problem... the android selection prompt do not disappear after selection... see the red circle form screenshot.

Screenshot_20200510-030135

Visiting your website 5.2 inch phone - No real space to edit

Screenshot_20200510-123315

And another screenshot from a larger phone 6.7 inch

Screenshot_2020-05-10-12-15-57-661_com android chrome

You must add an icon version for font type, font size, paragraph and use only ONE toolbar with a popup button - toolbox for the rest of buttons may be something like this:

Figure-1_The-Toolbox-menu-always-available-in-the-Mac-menu-bar

another solution from CKEditor

Screenshot_2020-05-10-13-41-45-957_com android chrome

or even better look at Microsoft word for mobile/desktop that combine tabs and toolbars. I think that is the best solution (elegant, professional, space saving) for mobile, desktop, and the inline editor when you want more buttons/options.

word-mobile-dead

I hope that the next version will be usable for mobile apps / websites. On the other hand excepting this bug (prompt bug) and design problems ... you have done a very good job.

Thank you in advance,
Paul

@vanillamasonry vanillamasonry changed the title Serious mobile view problems. Serious mobile view problems - near 0 editing space May 10, 2020
@JiHong88
Copy link
Owner

Hi, @vanillamasonry
Thank you for your interest in this project!

  1. Focus:
    The editor's cursor disappears only when the editor loses focus.
    It is a bad practice to lose focus whenever the editor clicks a button on the toolbar.
    And whenever the editor loses focus, the input area at the bottom will disappear.
    As a result, each time the button on the toolbar is clicked, the input area at the bottom disappears and reappears.
    This is a bad experience for the user.

  2. Toolbar buttons:
    I agree with your opinion.
    Currently you can define a container plugin, but it is very lacking.
    In the next version, I'll improve the responsive and button layout.

Thank you.

@vanillamasonry
Copy link
Author

vanillamasonry commented May 11, 2020

Dear Lee,

First of all I want to thank you for your fast reply, taking in consideration my suggestion and clarifying the Focus issue.

On the hand I have setup the editor in one application and after
creating -> editing -> deleting (destroy +null) -> creating again with the saved content I get the following problem (error):

suned

Beautifying the suneditor.min.js and tracking down the error I have found that
( no d.history.push(!1) in the else statement ) is causing the error

setContents: function(t) {
const n = this.convertContentsForEditor(t);
if (this._resetComponents(), d._variable.isCodeView) {
const e = this.convertHTMLForCodeView(n);
d._setCodeView(e)
} else e.element.wysiwyg.innerHTML = n, d.history.push(!1) <- HERE
},

removing ", d.history.push(!1)" from the else statement, the loading, creation editing etc... was working without any errors. I have no idea what "d.history.push(!1)" is doing and I am wondering if is OK to delete it

I hope that you will have time to review also this problem for the next release.

Thank you,
Paul

JiHong88 added a commit that referenced this issue May 17, 2020
add: functions-setToolbarButtons
@JiHong88 JiHong88 added the bug label May 17, 2020
JiHong88 added a commit that referenced this issue May 18, 2020
modify: menu tray
JiHong88 added a commit that referenced this issue May 21, 2020
@JiHong88
Copy link
Owner

JiHong88 commented Jun 9, 2020

The 2.30.0 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants