Add support for nix-darwin's Nix Apps directory #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of this pull request
This PR adds support for apps installed via nix-darwin. nix-darwin installs apps into a symlinked directory at
/Applications/Nix Apps. Since OpenInTerminal ignores aliases/symlinks, these apps were previously not picked up.It also includes fixes for nixpkgs's iTerm, IntelliJ IDEA Community Edition, and PyCharm Community Edition packages. nix installs iTerm as
iTerm2.app, and IntelliJ and PyCharm withCEappended to the app name. OpenInTerminal did not previously recognize these names.Does this solve an existing issue? If so, add a link to it
#183, partially. It does not add support for nix installed apps without a .app
Steps to test this feature
environment.systemPackages, for exampleiterm2Screenshots
-
Additional info
-