fix: resolve comments

Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao · Sep 21, 2022 · a0f4714 · a0f4714
1 parent 0af93b2
commit a0f4714
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/signature/jws/conformance_test.go b/signature/jws/conformance_test.go
@@ -22,8 +22,8 @@ var (
 	// signedAttributes for signing request
 	signedAttributes = signature.SignedAttributes{
 		SigningScheme: "notary.x509",
-		SigningTime:   signingTime.Truncate(time.Second),
-		Expiry:        expiry.Truncate(time.Second).Add(time.Hour * 24),
+		SigningTime:   signingTime,
+		Expiry:        expiry.Add(time.Hour * 24),
 		ExtendedAttributes: sortAttributes([]signature.Attribute{
 			{Key: "signedCritKey1", Value: "signedCritValue1", Critical: true},
 			{Key: "signedKey1", Value: "signedValue1", Critical: false},

diff --git a/signature/jws/envelope.go b/signature/jws/envelope.go
@@ -93,7 +93,7 @@ func (e *envelope) Verify() (*signature.EnvelopeContent, error) {
 	}
 
 	if len(e.base.Header.CertChain) == 0 {
-		return nil, &signature.InvalidSignatureError{Msg: "certificate chain is not set"}
+		return nil, &signature.InvalidSignatureError{Msg: "certificate chain is not present"}
 	}
 
 	cert, err := x509.ParseCertificate(e.base.Header.CertChain[0])
@@ -169,7 +169,7 @@ func (e *envelope) signerInfo(protected *jwsProtectedHeader) (*signature.SignerI
 		return nil, &signature.InvalidSignatureError{Msg: err.Error()}
 	}
 	if len(sig) == 0 {
-		return nil, &signature.InvalidSignatureError{Msg: "cose envelope missing signature"}
+		return nil, &signature.InvalidSignatureError{Msg: "signature missing in jws-json envelope"}
 	}
 	signerInfo.Signature = sig