Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix teamcity-messages for pylint >= 2.8 #242

Merged
merged 1 commit into from
May 20, 2021
Merged

Fix teamcity-messages for pylint >= 2.8 #242

merged 1 commit into from
May 20, 2021

Conversation

Tirzono
Copy link
Contributor

@Tirzono Tirzono commented Apr 26, 2021

Pylint made changes so pylint.__pkginfo__.version does not exist anymore and can be accessed now by pylint.__pkginfo__.__version__. This PR makes sure it works for both pylint >= 2.8 and pylint < 2.8.

Related to pylint-dev/pylint#4399

@Tirzono
Copy link
Contributor Author

Tirzono commented Apr 27, 2021

The build is failing but I don't think this is an issue with the change I made, but rather with the fact that it's been a while that we've run tests for teamcity-messages and some thing got broken over time.

@kolibri91
Copy link

kolibri91 commented Apr 27, 2021

Can you please tell me in which version this fix will be released?

@Tirzono
Copy link
Contributor Author

Tirzono commented May 4, 2021

@mikekidya @throwable-one @madlexa would you be willing to have a look at this one? :)

@esztermarton
Copy link

Nice change! Here's the commit that caused this. Would be great to have a new version of tc messages with this!

@mikekidya
Copy link
Member

Sorry for the delay and thank you for the PR, changes look cool to me.
According to JetBrains policies we can only accept PRs from contributors who signed JetBrains CLA. Could you please consider signing it?

@Tirzono
Copy link
Contributor Author

Tirzono commented May 19, 2021

Hi @mikekidya,

Thank you for your reply. I signed the JetBrains CLA. Please let me know if anything else is needed.

@mikekidya mikekidya self-requested a review May 20, 2021 06:22
@mikekidya mikekidya merged commit 2c3c2d0 into JetBrains:master May 20, 2021
@Tirzono
Copy link
Contributor Author

Tirzono commented May 24, 2021

Hi @mikekidya,

Would it be possible to do a new release so I can update pylint again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants