Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty service endpoint, use default region endpoint. #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pennyclip
Copy link

(Second attempt at this one)
Hey Crew,

Back again with another small change suggestion. While we were testing the plugin to first deploy to multiple regions at the same time, we also wanted to have the choice for us to deploy to a particular region. It would be nice if we could do this without having to parameterize the region AND the service endpoint, or make another configuration.

The code already determines if the service endpoint is not empty when it is looking to build the client, and it should work just fine with region alone.

 if (StringUtil.isNotEmpty(myServiceEndpoint)) {
      builder.setEndpointConfiguration(new AwsClientBuilder.EndpointConfiguration(myServiceEndpoint, myRegion));
    } else {
      builder.withRegion(myRegion);
    }

If there are concerns about making this optional, I would love to hear that feedback. Thanks for your time.

Jon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant