Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend: support URL navigation in string literals #519

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Frontend: support URL navigation in string literals #519

merged 4 commits into from
Apr 28, 2023

Conversation

DedSec256
Copy link
Collaborator

@DedSec256 DedSec256 commented Apr 24, 2023 •
edited
Loading

image

@DedSec256 DedSec256 force-pushed the net232-dedsc256-url-in-strings branch from b7768bc to 5aa5263 Compare April 24, 2023 23:12
@nojaf
Copy link
Contributor

nojaf commented Apr 25, 2023

Hi @DedSec256, does this open the door for https://youtrack.jetbrains.com/issue/RIDER-73590 as well?

@DedSec256
Copy link
Collaborator Author

DedSec256 commented Apr 25, 2023 •
edited
Loading

@nojaf, for sure! :)

image

@nojaf
Copy link
Contributor

nojaf commented Apr 25, 2023

Nice!

@DedSec256 DedSec256 assigned auduchinok and unassigned auduchinok Apr 28, 2023
@DedSec256 DedSec256 requested a review from auduchinok April 28, 2023 13:06
@auduchinok
Copy link
Collaborator

@DedSec256 There're some TODOs, is it OK to leave them as is?

@DedSec256
Copy link
Collaborator Author

Yes, these methods will be implemented in future PRs about injections; they are not needed for URL's

@DedSec256 DedSec256 merged commit 35c02b7 into net232 Apr 28, 2023
@DedSec256 DedSec256 deleted the net232-dedsc256-url-in-strings branch April 28, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auduchinok auduchinok auduchinok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DedSec256 @nojaf @auduchinok