Update signature parameter name #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
reviewed
Sep 26, 2022
There was a problem hiding this comment.
@nojaf The `memberDeclaration addition is a good change to the initial code, thanks! Could you also check other kinds of member declarations, please?
ReSharper.FSharp/src/FSharp.Psi.Intentions/src/QuickFixes/UpdateParameterNameInSignatureFix.fs
Outdated
Show resolved
Hide resolved
ReSharper.FSharp/src/FSharp.Psi.Intentions/src/QuickFixes/UpdateParameterNameInSignatureFix.fs
Outdated
Show resolved
Hide resolved
ReSharper.FSharp/src/FSharp.Psi.Intentions/src/QuickFixes/UpdateParameterNameInSignatureFix.fs
Show resolved
Hide resolved
ReSharper.FSharp/src/FSharp.Psi.Intentions/src/QuickFixes/UpdateParameterNameInSignatureFix.fs
Outdated
Show resolved
Hide resolved
auduchinok
approved these changes
Sep 27, 2022
ReSharper.FSharp/src/FSharp.Psi.Intentions/src/QuickFixes/UpdateParameterNameInSignatureFix.fs
Outdated
Show resolved
Hide resolved
ReSharper.FSharp/src/FSharp.Psi.Intentions/src/QuickFixes/UpdateParameterNameInSignatureFix.fs
Outdated
Show resolved
Hide resolved
ReSharper.FSharp/src/FSharp.Psi.Intentions/src/QuickFixes/UpdateParameterNameInSignatureFix.fs
Outdated
Show resolved
Hide resolved
ReSharper.FSharp/src/FSharp.Psi.Intentions/src/QuickFixes/UpdateParameterNameInSignatureFix.fs
Outdated
Show resolved
Hide resolved
Comment on lines
61
to
67
| | :? IReferencePat as rp -> | ||
| BindingSignatureNavigator.GetByHeadPattern(rp) | ||
| |> Option.ofObj | ||
| |> Option.map (fun bs -> bs.ReturnTypeInfo.ReturnType) | ||
| | :? IMemberSignature as ms -> | ||
| Some(ms.ReturnTypeInfo.ReturnType) | ||
| | :? IConstructorSignature as cs -> |
There was a problem hiding this comment.
I'll think about unifying these types.
ReSharper.FSharp/src/FSharp.Psi.Intentions/src/QuickFixes/UpdateParameterNameInSignatureFix.fs
Outdated
Show resolved
Hide resolved
…rogramming session.
nojaf
force-pushed
the
update-signature-parameter-name
branch
from
d893069 to
570ebec
Compare
auduchinok
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@auduchinok our initial attempt didn't seem to work for members so I made some changes.
I'm also not 100% convinced the unit tests assert the
.fsifiles.They always seem to pass.