Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waterfall_plot: tooltips don't work with column names from original dataset #1153

Closed
ASmirnov-HORIS opened this issue Aug 5, 2024 · 0 comments
Closed

waterfall_plot: tooltips don't work with column names from original dataset #1153

ASmirnov-HORIS opened this issue Aug 5, 2024 · 0 comments
Labels
failure Crash, exception occurs
Milestone
2024Q3

Comments

@ASmirnov-HORIS
Copy link
Collaborator

Example:

data = {
    'cat': ['A', 'B'],
    'val': [1, 2],
}
waterfall_plot(data, 'cat', 'val', relative_tooltips=layer_tooltips().line("@cat/@..xlabel.."))

throws IllegalArgumentException; expected:
@ASmirnov-HORIS ASmirnov-HORIS added the failure Crash, exception occurs label Aug 5, 2024
@alshan alshan added this to the 2024Q3 milestone Aug 19, 2024
ASmirnov-HORIS added a commit that referenced this issue Aug 28, 2024
@ASmirnov-HORIS
Waterfall: Fix #1152 and fix #1153 by preserving original dataset dur…
1e0781d 
…ing all statistical manipulations. Use only one dataset for all layers.
ASmirnov-HORIS added a commit that referenced this issue Aug 29, 2024
@ASmirnov-HORIS
waterfall: Mention fixes of #1152 and #1153 in the future_changes.md …
3142e84 
…file.
@MKoroteev-HORIS MKoroteev-HORIS changed the title waterfall_plot: tooltips doesn't work with column names from original dataset waterfall_plot: tooltips don't work with column names from original dataset Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
failure Crash, exception occurs
Projects
None yet
Milestone
2024Q3
Development

No branches or pull requests
2 participants
@alshan @ASmirnov-HORIS