Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Variable Fonts in Desktop, Native, Web #1623

Merged
merged 36 commits into from
Nov 5, 2024
Merged

Support Variable Fonts in Desktop, Native, Web #1623

merged 36 commits into from
Nov 5, 2024

Conversation

adamglin0
Copy link

@adamglin0 adamglin0 commented Oct 8, 2024 •
edited by terrakok
Loading

Support for Variable Font in platforms other than Android.

Fix Issue Youtrack

Testing

Write Sample In Compose MPP Demo

  • Desktop run ./gradlew :compose:mpp:demo:runDesktop
  • JS run ./gradlew :compose:mpp:demo:jsRun
  • IOS run ./compose/mpp/demo/regenerate_xcode_project.sh

For more details on how to run the mpp demo, please refer to MULTIPLATFORM.md
Should tested by QA.

How to use

Font(
      identity = "FontName",
      data = fontData,
      variationSettings = FontVariation.Settings()
)

Record

desktop.mov
js.mov
iOS.mp4

Release Notes

Features - Multiple Platforms

  • Support Variable Fonts In All Platforms

@adamglin0
add variable font to mpp demo
9946159
@adamglin0
add variationSettings
ba6e92f
@adamglin0
add variationSettings in PlatformFont
b8af5d1
@adamglin0
fix a bug
d53477e
@adamglin0
implement variable fonts
b960295
@adamglin0
remove an exception throwing
32c3789
@adamglin0
add a few@Composable Font
e8a61e8
@adamglin0
add sample
bb0033f
@adamglin0
add RobotFlex font to test
86b96fc
@adamglin0
Add a font that does not support variables.
1fd7932
@adamglin0
Merge remote-tracking branch 'origin/jb-main' into feature/variable-font
2b5529e 
# Conflicts:
#	compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/platform/PlatformFont.skiko.kt
@adamglin0
revert FontFamilies.kt
bc8fd85
@adamglin0
add VariableFonts.kt
a8f31c8
@adamglin0
add js test
95a7c9b
@adamglin0
add loadVariableFont in native
07b641e
@adamglin0
add fonts to xcodegen
a47b25b
@adamglin0
WIP
93ee8a8
@adamglin0
implement loadResource function
043c983
@adamglin0
remove unused script
02f4d24
@adamglin0
fix lint
b3a0a4b
@adamglin0
update xcodegen
2ddbaa2
@adamglin0 adamglin0 marked this pull request as ready for review October 9, 2024 14:03
@adamglin0
Copy link
Author

@MatkovIvan Hello, how do I add a reviewer to this PR?

@adamglin0 adamglin0 requested a review from kropp October 15, 2024 12:29
@adamglin0 adamglin0 requested a review from kropp October 16, 2024 07:10
@kropp kropp merged commit 3fa227e into JetBrains:jb-main Nov 5, 2024
2 checks passed
@ASalavei ASalavei mentioned this pull request Nov 6, 2024
Merged
ASalavei added a commit that referenced this pull request Nov 6, 2024
@ASalavei
Update ui-text API dump (#1682)
d5e7dca 
API dump update after the
[MR](#1623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrakok terrakok terrakok approved these changes

@kropp kropp kropp approved these changes

@MatkovIvan MatkovIvan Awaiting requested review from MatkovIvan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamglin0 @kropp @MatkovIvan @terrakok