Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the hyphen_bar.liga less_asterisk.liga kern of -1 intentional or accidental? #297

Closed
arrowtype opened this issue Aug 28, 2020 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@arrowtype
Copy link

I’ve noticed that the hyphen_bar.liga & less_asterisk.liga have a kern of -1 in the Regular weight. Is this intentional or accidental?

https://github.com/JetBrains/JetBrainsMono/blob/09d45c95de9a6cdd8949892129cb76161b958d3e/source/UFO/Normal/JetBrains%20Mono-Regular.ufo/kerning.plist

I’m guessing it’s accidental (probably caused by hitting the wrong hotkey combo at some point), but the other possibility is that it could be a brilliant weird hack that makes the code ligatures work in Netbeans, which I am currently having issues with in my own project.

If you have any insight into this, I would really appreciate it! Or, if it’s an accident, no worries.

@philippnurullin
Copy link
Member

Hi @arrowtype . Sorry to disappoint, this is just a mistake. Thanks for pointing it out. Will correct it in next update.

Maybe that will help you. It seems like you exporting fonts from Robofont. Both JetBrains Mono & Fira Code mastered/exported from Glyphs app. So it may be a good idea to export Recursive from Glyphs too (free trial?) & compare the end results.
Sorry again & good luck with finding a solution.

@arrowtype
Copy link
Author

:) Thanks for the quick response!

Interesting suggestion; maybe I'll give that a try and see what f anything changes.

@philippnurullin philippnurullin added the bug Something isn't working label Aug 31, 2020
@philippnurullin philippnurullin added this to the v2.003 milestone Aug 31, 2020
philippnurullin added a commit that referenced this issue Oct 21, 2020
Major changes
— Added Greek alphabet #58
— Reworked diacritics #228
— Removed x-height increasing from hinting. Affects non Retina screens. #286 #265 #272 #262 #275
— A lot of tiding up of contours to meet Google Fonts criteria
Other updated and fixes
— Ligature for 0x (hexadecimal) prefix #98
— Lowered horizontal bar in Florin to make it more distinguishable form italic f #129
— Changes the 8 construction to make it more distinguishable from B and 0 #188
— Added Changelog #263
— Variable font correctly grouped in one family with Italics #270
— Reverted to previous construction of f #273
— Corrected OneNote line height #278
— Removed kerning pair #297
— Add Overline #298
— Increased difference between hyphen, en-dash, and em-dash #318
— Removed the "tail" in the italic a
@arrowtype
Copy link
Author

(Just posting for future reference in case someone else comes across this: the issue in Recursive was that these glyphs overflowed to the right, rather than the left. I had to basically move all points to the left in these glyphs, and shuffle around the placeholder in my OpenType feature. arrowtype/recursive#369 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants