Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting index_type (e.g., 'HASH' or 'BTREE') #949

Merged
merged 3 commits into from
Jun 15, 2020

Conversation

ryanpbrewster
Copy link
Contributor

@ryanpbrewster ryanpbrewster commented Jun 10, 2020

May address #895

@Tapac
Copy link
Contributor

Tapac commented Jun 14, 2020

@ryanpbrewster , please fix test compilation and I'll merge PR.

@ryanpbrewster
Copy link
Contributor Author

ryanpbrewster commented Jun 15, 2020

Updated, I believe the tests compile and pass now.

As a side note, I found it a bit tricky to get the tests to compile and run. I'm developing on a Mac, and it seems that the mysql test harness assumes a Linux distro. When I booted up an Ubuntu container and mounted the directory, I still ran into several issues with tests failing at master (several due to timestamp resolution issues, where my system seems to be rounding timestamps to millisecond resolution).

Is there any kind of contributor guide to getting set up to build and run tests? If not, would you be willing to review my notes as the beginnings of such a guide?

@Tapac
Copy link
Contributor

Tapac commented Jun 15, 2020

@ryanpbrewster , it's a known issue with embedded mysql (mxj) which should be replaced with test-containers.

timestamp resolution was broken when Java9+ used, but it should be fixed at master already. If you'll face them after updating to master please file an issue.

@Tapac Tapac merged commit 56863e0 into JetBrains:master Jun 15, 2020
@ryanpbrewster ryanpbrewster deleted the rpb/index-types branch June 15, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants